Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several frontend bugs #55

Merged
merged 12 commits into from
Feb 7, 2019
Merged

Fix several frontend bugs #55

merged 12 commits into from
Feb 7, 2019

Conversation

itaisteinherz
Copy link
Contributor

@itaisteinherz itaisteinherz commented Feb 5, 2019

This fixes some bugs in the frontend app:

  • The menu drawer doesn't contain any navigation buttons.
  • The Knowledge home button doesn't always navigate to the homepage.
  • When running a search, the search input stays focused and doesn't get blurred.
  • The footer credits are off on mobile devices.

@itaisteinherz itaisteinherz requested a review from R-Layer February 5, 2019 10:48
Copy link
Contributor

@R-Layer R-Layer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gj!
Not sure on the next dev script though: what exactly it does?

@itaisteinherz
Copy link
Contributor Author

Not sure on the next dev script though: what exactly it does?

It should be the same as next, but works a bit better for me. It basically starts the Next.js server and runs your app, as well as watches for code changes and does hot-reloading.

@itaisteinherz itaisteinherz merged commit 56af25b into chingu-voyage7:master Feb 7, 2019
@itaisteinherz itaisteinherz deleted the bugfixes branch February 7, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants