user/duperemove: move from main and update to 0.15 #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the CI failures in "Set up cbuild configuration" my fault? |
|
no, i'll fix it shortly |
|
should be ok now if you rebase |
autumnontape
force-pushed
the
duperemove-0.15
branch
from
66448e9 to
5d97bb6
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've updated duperemove to v0.15, and I've moved it to the user repository as q66 asked on IRC.
It fails to build with clang if
delete-duplicate-definition.patchisn't applied, but it somehow builds successfully with gcc. I don't know what's going on with this code, if the TODO was left undone by accident or what, but the patched version seems to work fine in practice. There's an issue in the upstream repository: markfasheh/duperemove#367Checklist