Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy __builtin_subcll in Xcode 14.3.1 on arm64 #294

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix buggy __builtin_subcll in Xcode 14.3.1 on arm64 #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ Documentation of all notable changes to the **intx** project.
The format is based on [Keep a Changelog],
and this project adheres to [Semantic Versioning].

## [0.9.3] — unreleased

### Fixed

- Fixed buggy `__builtin_subcll` in Xcode 14.3.1 on arm64.
[294](https://github.com/chfast/intx/pull/294)

## [0.9.2] — 2023-03-11

### Changed
Expand Down Expand Up @@ -179,6 +186,7 @@ and this project adheres to [Semantic Versioning].
[#99](https://github.com/chfast/intx/pull/99)


[0.9.3]: https://github.com/chfast/intx/compare/v0.9.2..release/0.9
[0.9.2]: https://github.com/chfast/intx/releases/v0.9.2
[0.9.1]: https://github.com/chfast/intx/releases/v0.9.1
[0.9.0]: https://github.com/chfast/intx/releases/v0.9.0
Expand Down
3 changes: 2 additions & 1 deletion include/intx/intx.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,8 @@ inline constexpr result_with_carry<uint64_t> addc(
inline constexpr result_with_carry<uint64_t> subc(
uint64_t x, uint64_t y, bool carry = false) noexcept
{
#if __has_builtin(__builtin_subcll)
// Use __builtin_subcll if available (except buggy Xcode 14.3.1 on arm64).
#if __has_builtin(__builtin_subcll) && __apple_build_version__ != 14030022
if (!is_constant_evaluated())
{
unsigned long long carryout = 0; // NOLINT(google-runtime-int)
Expand Down