Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 32-bit Windows build in CircleCI #283

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Enable 32-bit Windows build in CircleCI #283

merged 2 commits into from
Jan 24, 2023

Conversation

axic
Copy link
Collaborator

@axic axic commented Jan 4, 2023

This fixes a build failure. _umul128 is x64 only, so using _M_X64 for checking that.

@axic
Copy link
Collaborator Author

axic commented Jan 5, 2023

Will squash the 3rd and 1st commit, but left it to show the build failure.

circle.yml Outdated
command: |
$ErrorActionPreference = "Stop"
& 'C:\Program Files\Microsoft Visual Studio\2022\Community\Common7\Tools\Launch-VsDevShell.ps1' -Arch x86
cd ~/build
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use working_directory: ~/build

@axic axic requested a review from chfast January 24, 2023 23:20
@chfast chfast merged commit 42750ef into master Jan 24, 2023
@chfast chfast deleted the ci-windows branch January 24, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants