Fix StripPrefixError on windows when including templates #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
My colleagues use windows and were surprised by an error when trying to include other templates.
I was able to track this down to the glob pattern creation logic, which has unix path separators hardcoded.
Simply using
Path.join
instead of the custom formatting seems to have resolved the issue for both of them.Thanks for this cli, its a simple solution for our simple problem!