Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StripPrefixError on windows when including templates #35

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

Nxllpointer
Copy link
Contributor

Hello!
My colleagues use windows and were surprised by an error when trying to include other templates.
I was able to track this down to the glob pattern creation logic, which has unix path separators hardcoded.
Simply using Path.join instead of the custom formatting seems to have resolved the issue for both of them.

Thanks for this cli, its a simple solution for our simple problem!

@chevdor
Copy link
Owner

chevdor commented Feb 10, 2025

Can you please fix the formatting ?
Ignore the second issue about flake. @alerque the quick-check you introduced in #27 seems to be failing on all changes. Would you mind having a look at the issue ?

@Nxllpointer
Copy link
Contributor Author

Sure. That should satisfy CI

@Nxllpointer
Copy link
Contributor Author

Regarding the flake, it seems to use rust 1.77.1, while lockfile v4 has been stabilized in 1.78.0. See rust-lang/cargo#14655
Not sure if nixos 24.05 already ships >1.78, if yes bumping the inputs should be fine, if not then switching to 25.11 or unstable

@chevdor
Copy link
Owner

chevdor commented Feb 10, 2025

I created this issue: #36
I would rather not block CI because of nix specificities.

@chevdor chevdor merged commit 4aad840 into chevdor:master Feb 10, 2025
4 of 5 checks passed
@Nxllpointer
Copy link
Contributor Author

Awesome thanks!

@chevdor
Copy link
Owner

chevdor commented Feb 10, 2025

Thanks for the PR, I am not using/testing Windows but happy to have it work there too.
If you find other issues, feel free to send a few PRs and we can release a new minor version including the Windows fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants