Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 0.12.1 tag #11

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Update to 0.12.1 tag #11

merged 4 commits into from
Jul 19, 2021

Conversation

sacha-l
Copy link
Contributor

@sacha-l sacha-l commented Jul 13, 2021

Updates the install command + other references to 0.12.0 tag.

chevdor
chevdor requested changes Jul 13, 2021
View reviewed changes
Copy link
Owner

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure all versions are bumped please

README.md Outdated
@@ -50,15 +50,15 @@ MacOS Homebrew users can use:

### Linux

wget https://github.com/chevdor/subwasm/releases/download/v0.12.0/subwasm_linux_amd64_v0.12.0 -O subwasm.deb
wget https://github.com/chevdor/subwasm/releases/download/v0.12.0/subwasm_linux_amd64_v0.12.1 -O subwasm.deb
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all good now.

@chevdor
Copy link
Owner

chevdor commented Jul 19, 2021

So for this PR, the md should not be fixed, instead, the .adoc should be updated and you run just md to get the markdown version. The asciidoc version is less error prone (and prevent the misses you experienced) as it uses a variable. As far as updating the usages (which are includes in the asciidoc source), they can be refreshed by running just doc or just usage. Not only it will bump the versions but also ensure that the doc is in sync.

I will be pushing a new commit to your PR soon.

@chevdor chevdor merged commit 50e6da6 into chevdor:master Jul 19, 2021
chevdor added a commit that referenced this pull request Jul 19, 2021
@chevdor
docs: update version to 0.12.1 (#11)
001e7df 
* Update to 0.12.1 tag

Co-authored-by: Chevdor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chevdor chevdor chevdor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sacha-l @chevdor