Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 update. #39

Merged
merged 78 commits into from
Apr 24, 2023
Merged

Python 3.10 update. #39

merged 78 commits into from
Apr 24, 2023

Conversation

dumol
Copy link
Contributor

@dumol dumol commented Mar 17, 2023

Scope

Update Python.

Changes

Use latest Python 3.10. (Python 3.11 builds fail because of python/cpython#101668.)

The libedit patch was removed, as it's not worth porting it to apply to 3.10 sources only for building on macOS…

Drive-by changes:

  • Removed 32bit Windows build.
  • Added an arm64 macOS build.
  • Build the Windows/macOS packages on whatever GitHub supports as -latest (currently Windows Server 2022 and macOS 12).
  • Build the generic Linux package on Amazon 2 with glibc 2.26.
  • Updated the other libs to build, where applicable: SQLite, libffi, xz.
  • Updated cryptography to newly-released version 40.0.1.
  • Build and check for PyNaCl.
  • Check for cffi too.
  • Collect and check for MarkupSafe, charset-normalizer, and pywin32 (the latter only on Windows).

Testing

Review changes and the automated test results.

Try the resulting test packages, e.g. https://bin.chevah.com:20443/testing/3.10.11.5cdf347/

@dumol
Copy link
Contributor Author

dumol commented Apr 12, 2023

Another thing that should be done for py3.10

we no longer need the -3 check

Done through f2a18c5.

@dumol dumol mentioned this pull request Apr 12, 2023
@dumol
Copy link
Contributor Author

dumol commented Apr 12, 2023

Went through all the comments once more, let me know if I missed something before approving this. Thanks!

@dumol
Copy link
Contributor Author

dumol commented Apr 13, 2023

For the record, I've also tried building the generic Linux package on Amazon Linux 1 (aka 2018.03), which has the same glibc version as RHEL 7. And which has gcc 7.2 available as an extra package.

The package builds with minimal changes, but it has the same issues as on CentOS 7, it links against /lib64/libfreebl3.so, which belongs to an irremovable system package.

@adiroiban
Copy link
Member

I am leaving a comment here, but most probably needs to be done in a separate ticket.

For the Windows version, besides the lib/python310.zip we also need to distribute the source code.

Without the source code, the python works, but debugging is hard.

So for Windows, besides the current embeddable version, we need to find a way to also get the source code avaiable inside the build folder

@dumol
Copy link
Contributor Author

dumol commented Apr 19, 2023

So for Windows, besides the current embeddable version, we need to find a way to also get the source code avaiable inside the build folder

Sure, no problem, I'll fill in a new ticket… But what sources you want included? The win package of python-package only has some include files in /python2.7-win-x64/lib/include/… You want more? All the source code of Python? Only some parts of it?

What kind of debugging you have in mind? Debugging Python binaries?

@dumol dumol merged commit 58d57c7 into main Apr 24, 2023
@dumol dumol deleted the python-update branch April 24, 2023 10:30
@dumol
Copy link
Contributor Author

dumol commented Apr 24, 2023

For the record, merged into master as discussed on #chevah last week on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants