[pull] master from apache:master #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…-core (#979) Closes: #979 Signed-off-by: Yu-Lin Chen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 81.53% 81.50% -0.04%
==========================================
Files 97 97
Lines 12625 12625
==========================================
- Hits 10294 10290 -4
- Misses 2050 2052 +2
- Partials 281 283 +2 ☔ View full report in Codecov by Sentry. |
Closes: #984 Signed-off-by: Peter Bacsko <[email protected]>
…#988) Closes: #988 Signed-off-by: Peter Bacsko <[email protected]>
Placeholder tracking data is maintained inside the application for scheduling. If the placeholder is released we update the counters in the tracking data. We have cases in which we do not do that correctly: * placeholders are smaller than the real allocation * placeholder does not have an allocation to replace * all allocations are removed from an application Closes: #986 Signed-off-by: Craig Condit <[email protected]>
Closes: #985 Signed-off-by: Craig Condit <[email protected]>
Closes: #983 Signed-off-by: Craig Condit <[email protected]>
…#989) Closes: #989 Signed-off-by: Craig Condit <[email protected]>
Closes: #987 Signed-off-by: Craig Condit <[email protected]>
Closes: #990 Signed-off-by: Craig Condit <[email protected]>
While releasing placeholders the allocated placeholders are counted twice in the tracking information. With YUNIKORN-2926 in place this happens if some but not all placeholders are allocated only. Mark unallocated placeholders that timeout as released to prevent scheduling issues. Closes: #991 Signed-off-by: Craig Condit <[email protected]>
The REST calls to get a statedump and the stacks of the system are exposed on the wrong endpoint. They belong in /debug and not in /ws/v1. Both are for troubleshooting only and the content is not stable. Placing a 301 redirect on the old endpoints for clients to follow. The proxy build into the web UI does not proxy the debug endpoints. Closes: #992 Signed-off-by: Craig Condit <[email protected]>
…993) Remove the Resource object from the REST response for the user and group trackers. Removed the usage of the DAO objects in the internal unit tests. The unit tests use new functions which directly expose the same structures without using the DAO. Cleanup: - remove export from internal functions (UserTracker, GroupTracker) - renamed functions to match their results (Manager) - update handler to call renamed functions in Manager - reimplemented test functions to not use DAO objects (Manager, UserTracker, GroupTracker, QueueTracker) - assert function changes to use new functions removing DAO usage (scheduler/utilites_test, scheduler/objects/utilites_test) Closes: #993 Signed-off-by: Craig Condit <[email protected]>
Only respond with the allowed methods for the request, not with a general all allowed set. OPTIONS is supported via the generic config. Add a test to make sure a change in router does not break that. Remove the Access-Control-Allow-Credentials as recommended in the RFC. We also do not use cookies or authentication so not relevant to set. Closes: #994 Signed-off-by: Craig Condit <[email protected]>
…rs (#996) YUNIKORN-2700 introduced a bug where allocations of previously-reserved tasks were not handled correctly in the case where we schedule on a different node than the reservation. Ensure that we unreserve and allocate using the proper node in both cases. Also introduce additional logging of allocations on nodes to make finding issues like this easier in the future. Closes: #996
…selection fails (#998) Closes: #998 Signed-off-by: Craig Condit <[email protected]>
Closes: #997 Signed-off-by: Craig Condit <[email protected]>
Remove the TrackedResource object from the REST response for the application. Moved the tracked resources into a separate object inside the app DAO, as we have done for other complex pieces. Cleanup exposure of the summary object to be testing only. Add DAO retrieval of TrackedResource type for the web handler. Closes: #999 Signed-off-by: Craig Condit <[email protected]>
Add preemption and priority details to the queue REST information. Currently the configuration is exposed via the properties. The properties contain the raw configuration values which need to be interpreted. Invalid configuration values are ignored and not set on the queue. This could cause an incorrect view of what is or should be active on the queue if based on the properties. Using the active values from the object to show the real state. Expose Partition level preemption flag as part of this change to complement the queue details. Closes: #995 Signed-off-by: Craig Condit <[email protected]>
Closes: #1000 Signed-off-by: Peter Bacsko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )