Skip to content

Commit

Permalink
[processor/k8sattributes] Support name:tag@digest image name format (o…
Browse files Browse the repository at this point in the history
…pen-telemetry#36145)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Fixed issue with `k8sattributesprocessor` where digest is not properly
separated from tag if both are present. used official docker library to
perform parsing.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes
open-telemetry#36131

<!--Describe what testing was performed and which tests were added.-->
#### Testing
unit tests
integration/e2e tests

<!--Describe the documentation added.-->
#### Documentation
N/A. Fields are already described correctly, this is simply fixing
parsing logic

<!--Please delete paragraphs that you did not use before submitting.-->
  • Loading branch information
spiffyy99 authored and chengchuanpeng committed Jan 26, 2025
1 parent 8e0d7e9 commit bc7dab6
Showing 1 changed file with 27 additions and 0 deletions.
27 changes: 27 additions & 0 deletions .chloggen/fix-k8s-image-parsing.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: processor/k8sattribute

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: fixes parsing of k8s image names to support images with tags and digests.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [36131]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]

0 comments on commit bc7dab6

Please sign in to comment.