Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 13 support hotfix #227

Closed
wants to merge 1 commit into from

Conversation

fluxc
Copy link

@fluxc fluxc commented Feb 1, 2023

Added fix for Android 13 request permission

@fredriksthlm
Copy link

fredriksthlm commented Mar 14, 2023

Is this now finally verified and works fine for Android13? No crashes anymore?
Do you use this in production @fluxc ?

@fluxc
Copy link
Author

fluxc commented Mar 20, 2023

Yes is working fine in production for me.

@WouterWidgets
Copy link
Contributor

I would love to see this merged :-)

@vladansaracpv
Copy link

Any merge/release date for this? Deadline is closing in :)

andresmq pushed a commit to cyclosproject/cordova-plugin-firebase-messaging that referenced this pull request Sep 5, 2023
@oselow
Copy link

oselow commented Sep 27, 2023

The deadline is coming up :) No merge planned?
It doesn't work when I try to add the fix branch so we are waiting for the fix :p

Ty

@jacobg
Copy link

jacobg commented Oct 17, 2023

The plugin needs to implement onRequestPermissionResult in order to callback into the web code and resolve the requestPermission() promise.

@chemerisuk
Copy link
Owner

Fixed in v8.

@chemerisuk chemerisuk closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants