Remove custom LDFLAGS and CFLAGS for osx. #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
got relevant busted specs. |
lamont-granquist
approved these changes
Feb 25, 2019
|
(you're good to go if you just fix them though) |
OSX 10.5 or greater can use '-Wl,-rpath,/path/to/lib' so we can use the default flags. Signed-off-by: Jon Morrow <[email protected]>
jonsmorrow
force-pushed
the
jm/rpath_mac_ldflags
branch
from
bc554ec to
2a1e68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSX 10.5 or greater can use '-Wl,-rpath,/path/to/lib' so we can use
the default flags.
Signed-off-by: Jon Morrow [email protected]
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan