Add hostArchitectures to macOS Distribution file #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless hostArchitectures is set, macOS 11 will assume that the package is x86_64 and require Rosetta 2. * https://scriptingosx.com/2020/12/platform-support-in-macos-installer-packages-pkg/ * https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW7 Signed-off-by: Tom Duffield <[email protected]>
lamont-granquist
approved these changes
Mar 12, 2021
In our code we call .open on a different object based on which version of Ruby we are using. We need to ensure we reflect that in our tests. Signed-off-by: Tom Duffield <[email protected]>
This was referenced Mar 15, 2021
timsutton
added a commit
to timsutton/omnibus-ruby
that referenced
this pull request
Jul 12, 2023
- this would be addressed already if the omnibus fork included more recent upstream updates from chef/omnibus - chef#1005 is a better fix but it depends on safe_architecture method added at some other point
10 tasks
timsutton
added a commit
to timsutton/omnibus-ruby
that referenced
this pull request
Apr 10, 2024
- this would be addressed already if the omnibus fork included more recent upstream updates from chef/omnibus - chef#1005 is a better fix but it depends on safe_architecture method added at some other point
timsutton
added a commit
to timsutton/omnibus-ruby
that referenced
this pull request
Jun 26, 2024
- this would be addressed already if the omnibus fork included more recent upstream updates from chef/omnibus - chef#1005 is a better fix but it depends on safe_architecture method added at some other point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unless hostArchitectures is set, macOS 11 will assume that the package is x86_64 and require Rosetta 2 on arm64.
This was first validated by manually modifying the
Distributionfile of an existing package, repackaging it, and then trying to re-install it. It was subsequently validated against a build of harmony. See below the error cases.When you try to install arm64 package onto x86_64
When you try to install an arm64 package without hostArchitectures setting onto arm64
Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan