Merge pull request #897 from chef/jsinha/fix_dmg

Unmount dmg before detaching
chef · Aug 28, 2019 · ab39cf0 · ab39cf0
2 parents c4c0c51 + 06adefd
commit ab39cf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/omnibus/compressors/dmg.rb b/lib/omnibus/compressors/dmg.rb
@@ -258,6 +258,9 @@ def compress_dmg
         shellout! <<-EOH.gsub(/^ {10}/, "")
           chmod -Rf go-w "/Volumes/#{volume_name}"
           sync
+          hdiutil unmount "#{@device}"
+          # Give some time to the system so unmount dmg
+          sleep 5
           hdiutil detach "#{@device}" &&  \
           hdiutil convert \\
             "#{writable_dmg}" \\

diff --git a/spec/unit/compressors/dmg_spec.rb b/spec/unit/compressors/dmg_spec.rb
@@ -217,6 +217,9 @@ module Omnibus
           .with <<-EOH.gsub(/^ {12}/, "")
             chmod -Rf go-w "/Volumes/Project One"
             sync
+            hdiutil unmount "#{device}"
+            # Give some time to the system so unmount dmg
+            sleep 5
             hdiutil detach "#{device}" &&\
             hdiutil convert \\
               "#{staging_dir}/project-writable.dmg" \\