Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in metadata parsing while creating a compute instance #83

Merged
merged 2 commits into from
Jan 26, 2016

Conversation

SinisterLight
Copy link
Contributor

I am trying to create a new instance, and passing sshKeys as metadata.
My ssh public key has "=" a character, due to which metadata was not getting updated properly

 --gce-metadata sshKeys="user:ssh-rsa blah,blah== me@example

But when instance is getting created it has

ssh-rsa blah,blah

as ssh key and drops "== me@example" at the end

@SinisterLight
Copy link
Contributor Author

so looking through code problem was with the metadata parsing.

mkey, mvalue = pair.split('=')

this doesn't treat pair as a true key and value pair
Fixed it in pull request

@SinisterLight
Copy link
Contributor Author

Added a failing test too

@SinisterLight
Copy link
Contributor Author

Any comments ?

@erjohnso
Copy link
Contributor

Sorry for the silence @SinisterLight, this lgtm. Merging now.

erjohnso added a commit that referenced this pull request Jan 26, 2016
Error in metadata parsing while creating a compute instance
@erjohnso erjohnso merged commit fdaba3d into chef:master Jan 26, 2016
@SinisterLight
Copy link
Contributor Author

@erjohnso Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants