Allow enabling ip forward when creating instance #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way metadata was being sent to google api was wrong. According to API reference https://cloud.google.com/compute/docs/reference/latest/instances#resource metadata items are hashes like this: {'key': mykey, 'value': myvalue} However they were being passed as: {'mykey': 'myvalue'}
|
Thanks for the updates! |
paulrossman
added a commit
that referenced
this pull request
Feb 24, 2015
Changes in this pull request: - enabling ip forward when creating instance - creating disk with different disk types (pd, ssd) - allow passing metadata and metadata fixes - added .ruby-version to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.