Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta16 api support #24

Merged
merged 14 commits into from
Nov 25, 2013
Merged

v1beta16 api support #24

merged 14 commits into from
Nov 25, 2013

Conversation

paulrossman
Copy link
Contributor

  • v1beta16 introduces a new quota structure that has the following changes:
    • All zone quotas have been removed and will no longer be enforced or reported.
    • Regional resources now have quota information and take the place of old zone quotas.
    • Certain global quotas have been removed or migrated to become regional quotas.
  • Added support for GCE regions
    • knife google region list
  • Added support for GCE projects
    • knife google project list
  • Added service account scope support when creating new servers.
  • Update UA string to knife-google-v1beta16
  • Bumped knife-google version to 1.2.0

@adamedx
Copy link

adamedx commented Nov 15, 2013

Overall changes look good (I focused on the non-cosmetic commits). Only issues I have at this point are in the README:

  1. What's the key purpose of the project list command? So I can know if I have enough resources to spin up instances?
  2. I'm sort of confused about when to use zones vs. regions. I was able to spin up instances fine just specifying a zone. Maybe this is very obvious for GCE users and doesn't belong in this readme, but at least a little information would help me here in ensuring I get all the reasoning behind these changes.

@erjohnso
Copy link
Contributor

@paulrossman - friendly ping. Perhaps a bit more clarity in the README around the points that Adam raised?

@paulrossman
Copy link
Contributor Author

I'll make changes to the readme and update the PR today.

erjohnso added a commit that referenced this pull request Nov 25, 2013
@erjohnso erjohnso merged commit e1abe0c into master Nov 25, 2013
@paulrossman paulrossman deleted the v1beta16 branch December 11, 2013 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants