Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knife-google master should be deployed to RubyGems #57

Closed
adamedx opened this issue Mar 25, 2015 · 5 comments
Closed

knife-google master should be deployed to RubyGems #57

adamedx opened this issue Mar 25, 2015 · 5 comments

Comments

@adamedx
Copy link

adamedx commented Mar 25, 2015

@gmiranda23, can you update RubyGems with the latest version of this gem? Sync with @siddheshwar-more who is getting the specs green now.

@gmiranda23
Copy link

@adamedx can you grant me access to push that gem? same handle as github.

@mansona
Copy link

mansona commented Mar 27, 2015

I would like to +1 this because we started getting a pretty horriffic error when trying to use the 1.3.1 version:

/opt/chefdk/embedded/lib/ruby/2.1.0/time.rb:325:in `_parse': no implicit conversion of nil into String (TypeError)
        from /opt/chefdk/embedded/lib/ruby/2.1.0/time.rb:325:in `parse'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/zone_operation.rb:45:in `from_hash'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/resource.rb:28:in `initialize'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:35:in `new'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:35:in `create'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:45:in `insert'
        from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/chef/knife/google_server_create.rb:427:in `run'
        from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:417:in `block in run_with_pretty_exceptions'
        from /opt/chefdk/embedded/apps/chef/lib/chef/local_mode.rb:38:in `with_server_connectivity'
        from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:416:in `run_with_pretty_exceptions'
        from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:213:in `run'
        from /opt/chefdk/embedded/apps/chef/lib/chef/application/knife.rb:139:in `run'
        from /opt/chefdk/embedded/apps/chef/bin/knife:25:in `<top (required)>'
        from /usr/bin/knife:40:in `load'
        from /usr/bin/knife:40:in `<main>'

Note the line number on zone_operation is wrong because i added some logging. Data was missing a startTime so it was effectively this line that was dying: https://github.com/chef/knife-google/blob/master/lib/google/compute/zone_operation.rb#L42

@paulrossman
Copy link
Contributor

In the meantime and if you use bundler maybe pull from github?

On Fri, Mar 27, 2015, 13:08 Chris Manson [email protected] wrote:

I would like to +1 this because we started getting a pretty horriffic
error when trying to use the 1.3.1 version:

/opt/chefdk/embedded/lib/ruby/2.1.0/time.rb:325:in _parse': no implicit conversion of nil into String (TypeError) from /opt/chefdk/embedded/lib/ruby/2.1.0/time.rb:325:inparse'
from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/zone_operation.rb:45:in from_hash' from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/resource.rb:28:ininitialize'
from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:35:in new' from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:35:increate'
from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/google/compute/creatable_resource_collection.rb:45:in insert' from /var/lib/jenkins/.chefdk/gem/ruby/2.1.0/gems/knife-google-1.3.1/lib/chef/knife/google_server_create.rb:427:inrun'
from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:417:in block in run_with_pretty_exceptions' from /opt/chefdk/embedded/apps/chef/lib/chef/local_mode.rb:38:inwith_server_connectivity'
from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:416:in run_with_pretty_exceptions' from /opt/chefdk/embedded/apps/chef/lib/chef/knife.rb:213:inrun'
from /opt/chefdk/embedded/apps/chef/lib/chef/application/knife.rb:139:in run' from /opt/chefdk/embedded/apps/chef/bin/knife:25:in<top (required)>'
from /usr/bin/knife:40:in load' from /usr/bin/knife:40:in

'

Note the line number on zone_operation is wrong because i added some
logging. Data was missing a startTime so it was effectively this line that
was dying:
https://github.com/chef/knife-google/blob/master/lib/google/compute/zone_operation.rb#L42


Reply to this email directly or view it on GitHub
#57 (comment).

@mansona
Copy link

mansona commented Dec 14, 2015

I've just come across this same error again 😭 completely forgot that I posted here in March!!

I was going to respond this back then but I got off the case, I'm not a rubyist so I don't know what use bundler maybe pull from github means. Can you elaborate?

Also has there been any progress on this issue?

@adamleff
Copy link
Contributor

Closing this out. knife-google is on Rubygems, and the recent work has been released as v2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants