Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup GitHub actions error messages #4037

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

gene1wood
Copy link
Contributor

Description

Update download-file-action GitHub Action to v1.1.2

Currently the lint GitHub action produces these warnings

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, carlosperate/[email protected], DavidAnson/markdownlint-cli2-action@v4. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This is resolved in download-file-action at v1.1.2

https://github.com/carlosperate/download-file-action/releases/tag/v1.1.2

This commit updates the action to use this new version

Update markdownlint-cli2-action to version 5

Currently the lint GitHub action produces these warnings

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, carlosperate/[email protected], DavidAnson/markdownlint-cli2-action@v4. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This is resolved for markdownlint-cli2-action by updating to v5.0.0

https://github.com/DavidAnson/markdownlint-cli2-action/releases/tag/v5.0.0

This commit updates the action to use that new version

Update GitHub actions/checkout to v3

Currently when the linter runs it produces this warning

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This commit updates the GitHub action to use the actions/checkout action that uses Node.js 16

Lint fixes

This also resolves the lint error

content/custom_resource_glossary.md:258:44 MD050/strong-style Strong style should be consistent [Expected: underscore; Actual: asterisk]

Definition of Done

Issues Resolved

Related PRs

Check List

  • Spell Check
  • Local build
  • Examine the local build
  • All tests pass

Currently when the linter runs it produces this warning

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This commit updates the GitHub action to use the actions/checkout action that uses Node.js 16

Signed-off-by: Gene Wood <[email protected]>
Currently the lint GitHub action produces these warnings

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, carlosperate/[email protected], DavidAnson/markdownlint-cli2-action@v4. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This is resolved for markdownlint-cli2-action by updating to v5.0.0

https://github.com/DavidAnson/markdownlint-cli2-action/releases/tag/v5.0.0

This commit updates the action to use that new version

Signed-off-by: Gene Wood <[email protected]>
Currently the lint GitHub action produces these warnings

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, carlosperate/[email protected], DavidAnson/markdownlint-cli2-action@v4. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

This is resolved in download-file-action at v1.1.2

https://github.com/carlosperate/download-file-action/releases/tag/v1.1.2

This commit updates the action to use this new version

Signed-off-by: Gene Wood <[email protected]>
This resolves the lint error

```
content/custom_resource_glossary.md:258:44 MD050/strong-style Strong style should be consistent [Expected: underscore; Actual: asterisk]
```

Signed-off-by: Gene Wood <[email protected]>
@gene1wood gene1wood requested a review from a team as a code owner February 1, 2023 18:37
@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for chef-web-docs ready!

Name Link
🔨 Latest commit 8d0a567
🔍 Latest deploy log https://app.netlify.com/sites/chef-web-docs/deploys/63dc0399bff9d400083d003d
😎 Deploy Preview https://deploy-preview-4037--chef-web-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gene1wood!
tenor-216622490

@IanMadd IanMadd merged commit 227106c into chef:main Feb 2, 2023
@gene1wood gene1wood deleted the fixup_github_actions_error_messages branch February 2, 2023 18:49
@gene1wood
Copy link
Contributor Author

@IanMadd Welcome! Your GIF game is on point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants