Knife search issue: when search entries are more than 10K #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-server processing.
|
marcparadise
requested changes
Dec 2, 2024
talktovikas
changed the title
talktovikas
changed the title
jashaik
changed the title
jashaik
reviewed
Dec 9, 2024
| @@ -194,6 +194,7 @@ | |||
| {timeout, <%= @solr_timeout %>}, | |||
| {init_count, <%= @solr_http_init_count %>}, | |||
| {max_count, <%= @solr_http_max_count %>}, | |||
| {track_total_hits,true}, | |||
There was a problem hiding this comment.
read the config value from default.rb from attributes(Omnibus).
There was a problem hiding this comment.
Default value should be false for track_total_hits
jashaik
reviewed
Dec 9, 2024
| @@ -30,6 +30,7 @@ from_params(Provider, ObjType, QueryString, Start, Rows) -> | |||
| search_provider = Provider, | |||
| start = decode({nonneg_int, "start"}, Start, 0), | |||
| rows = decode({nonneg_int, "rows"}, Rows, 1000), | |||
| track_total_hits = envy:get(chef_index, track_total_hits, true, boolean), | |||
There was a problem hiding this comment.
Suggested change
| track_total_hits = envy:get(chef_index, track_total_hits, true, boolean), | |
| track_total_hits = envy:get(chef_index, track_total_hits, false, boolean), |
talktovikas
force-pushed
the
vikas/knife_index
branch
from
42bdf59 to
ebe9550
Compare
talktovikas
force-pushed
the
vikas/knife_index
branch
5 times, most recently
from
b268a4a to
6ca1f97
Compare
talktovikas
changed the title
|
Video Demo for this: knife_search_issue.mov |
talktovikas
force-pushed
the
vikas/knife_index
branch
2 times, most recently
from
b5fb55b to
624fc6f
Compare
marcparadise
approved these changes
Dec 18, 2024
github-actions
bot
added
the
Documentation
talktovikas
force-pushed
the
vikas/knife_index
branch
from
21e8951 to
ca90f2b
Compare
jashaik
force-pushed
the
vikas/knife_index
branch
from
ca90f2b to
fb89786
Compare
talktovikas
force-pushed
the
vikas/knife_index
branch
from
fb89786 to
2b39607
Compare
Signed-off-by: talktovikas <[email protected]> fixing omnibus issue. Signed-off-by: talktovikas <[email protected]> fixing pedant issue. Signed-off-by: talktovikas <[email protected]> binding at runtime. Signed-off-by: talktovikas <[email protected]> Doc Changes for knife index. Signed-off-by: talktovikas <[email protected]> adding default to toml file. Signed-off-by: talktovikas <[email protected]>
talktovikas
force-pushed
the
vikas/knife_index
branch
from
2b39607 to
0a22296
Compare
|
|
jashaik
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Please describe what this change achieves]
This PR contains the changes for issue on Jira:
https://progresssoftware.atlassian.net/browse/CHEF-5783
Issues Resolved
When user do
Knife search wildcard [ knife search 'name:*' -i | wc -l] was only providing 10k results where as user gets more than 10 when doing lets say [knife node list | wc -l].
The fix here contains adding track_total_hits value in the opensearch request body, If set as true will give all the data when searching using wildcard approach.
which tells the max_window_size a response can accommodate.
To use this feature change the value of
in the erchef which is false by default.
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List