Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new compliance searchbar #891

Merged
merged 4 commits into from
Jul 18, 2019

Conversation

vinay033
Copy link
Collaborator

Signed-off-by: vinay033 [email protected]

🔩 Description

In an effort to drive parity across the app, we'd like to make the compliance search bar be the same as the client runs search bar.

👍 Definition of Done

Compliance search bar is the same format as the client runs.

👟 Demo Script / Repro Steps

Screenshot from 2019-07-15 14-46-45
Screenshot from 2019-07-15 14-47-04

⛓️ Related Resources

#405

@vinay033 vinay033 self-assigned this Jul 15, 2019
@susanev susanev self-requested a review July 15, 2019 23:14
Copy link
Contributor

@lancewf lancewf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! The search bar is working well.

Copy link

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice! Tested it and worked locally.

Copy link

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!!!!! ⭐️

Copy link
Contributor

@susanev susanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinay033 the placeholder text color and border color appear to be different colors on the client runs vs compliance search bars. Any chance you can align those to be the same color? if so, the compliance colors are the ones we would like to use. If it makes more sense for that change to be a separate pr then feel free to ignore this comment.

Otherwise, looks and works great, thank you!!

@vinay033 vinay033 force-pushed the Vinay/MSYS-1044_compliance_new_searchbar branch from 8947bc3 to df99b1d Compare July 18, 2019 13:04
@vinay033
Copy link
Collaborator Author

@vinay033 the placeholder text color and border color appear to be different colors on the client runs vs compliance search bars. Any chance you can align those to be the same color? if so, the compliance colors are the ones we would like to use. If it makes more sense for that change to be a separate pr then feel free to ignore this comment.

Otherwise, looks and works great, thank you!!

I have added changes for this, please have a look.

@susanev susanev merged commit 8c346da into master Jul 18, 2019
@chef-ci chef-ci deleted the Vinay/MSYS-1044_compliance_new_searchbar branch July 18, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants