-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new compliance searchbar #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! The search bar is working well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiice! Tested it and worked locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!!!!! ⭐️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinay033 the placeholder text color and border color appear to be different colors on the client runs vs compliance search bars. Any chance you can align those to be the same color? if so, the compliance colors are the ones we would like to use. If it makes more sense for that change to be a separate pr then feel free to ignore this comment.
Otherwise, looks and works great, thank you!!
Signed-off-by: vinay033 <[email protected]>
Signed-off-by: vinay033 <[email protected]>
Signed-off-by: vinay033 <[email protected]>
8947bc3
to
df99b1d
Compare
I have added changes for this, please have a look. |
Signed-off-by: vinay033 <[email protected]>
Signed-off-by: vinay033 [email protected]
🔩 Description
In an effort to drive parity across the app, we'd like to make the compliance search bar be the same as the client runs search bar.
👍 Definition of Done
Compliance search bar is the same format as the client runs.
👟 Demo Script / Repro Steps
⛓️ Related Resources
#405