-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanju/remove pg password from a2 platform file #8674
Merged
Dmaddu
merged 3 commits into
CHEF-5668
from
sanju/remove_pg_password_from_a2_platform_file
Dec 12, 2024
Merged
Sanju/remove pg password from a2 platform file #8674
Dmaddu
merged 3 commits into
CHEF-5668
from
sanju/remove_pg_password_from_a2_platform_file
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
709648b
to
5b33ff9
Compare
Signed-off-by: “SanjuPal01” <[email protected]>
Signed-off-by: “SanjuPal01” <[email protected]>
Signed-off-by: “SanjuPal01” <[email protected]>
5b33ff9
to
88dace2
Compare
|
Dmaddu
approved these changes
Dec 12, 2024
jashaik
pushed a commit
that referenced
this pull request
Dec 31, 2024
* Storing password in secret helper Signed-off-by: “SanjuPal01” <[email protected]> * Adding Dex Component Changes Signed-off-by: “SanjuPal01” <[email protected]> * Reading password from secret helper in notification-service Signed-off-by: “SanjuPal01” <[email protected]> --------- Signed-off-by: “SanjuPal01” <[email protected]>
RoyShravani
pushed a commit
that referenced
this pull request
Jan 31, 2025
* Storing password in secret helper Signed-off-by: “SanjuPal01” <[email protected]> * Adding Dex Component Changes Signed-off-by: “SanjuPal01” <[email protected]> * Reading password from secret helper in notification-service Signed-off-by: “SanjuPal01” <[email protected]> --------- Signed-off-by: “SanjuPal01” <[email protected]>
SanjuPal01
added a commit
that referenced
this pull request
Feb 4, 2025
* Storing password in secret helper Signed-off-by: “SanjuPal01” <[email protected]> * Adding Dex Component Changes Signed-off-by: “SanjuPal01” <[email protected]> * Reading password from secret helper in notification-service Signed-off-by: “SanjuPal01” <[email protected]> --------- Signed-off-by: “SanjuPal01” <[email protected]>
SanjuPal01
added a commit
that referenced
this pull request
Feb 6, 2025
* Storing password in secret helper Signed-off-by: “SanjuPal01” <[email protected]> * Adding Dex Component Changes Signed-off-by: “SanjuPal01” <[email protected]> * Reading password from secret helper in notification-service Signed-off-by: “SanjuPal01” <[email protected]> --------- Signed-off-by: “SanjuPal01” <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Updated the implementation to store passwords in the secret-helper. Now, passwords are retrieved from the secret-helper for the respective components, instead of being read directly from the configuration.
⛓️ Related Resources
https://progresssoftware.atlassian.net/browse/CHEF-17478
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable