Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanju/remove pg password from a2 platform file #8674

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

SanjuPal01
Copy link
Collaborator

🔩 Description: What code changed, and why?

Updated the implementation to store passwords in the secret-helper. Now, passwords are retrieved from the secret-helper for the respective components, instead of being read directly from the configuration.

⛓️ Related Resources

https://progresssoftware.atlassian.net/browse/CHEF-17478

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Copy link

netlify bot commented Dec 5, 2024

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 88dace2
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/6756a6b84c87490008dfa9c6

@SanjuPal01 SanjuPal01 force-pushed the sanju/remove_pg_password_from_a2_platform_file branch from 709648b to 5b33ff9 Compare December 5, 2024 11:57
@SanjuPal01 SanjuPal01 force-pushed the sanju/remove_pg_password_from_a2_platform_file branch from 5b33ff9 to 88dace2 Compare December 9, 2024 08:13

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@YashviJain01 YashviJain01 changed the base branch from main to CHEF-5668 December 10, 2024 06:06
@SanjuPal01 SanjuPal01 self-assigned this Dec 10, 2024
@SanjuPal01 SanjuPal01 requested a review from a team December 10, 2024 06:26
@YashviJain01 YashviJain01 marked this pull request as ready for review December 10, 2024 06:29
@YashviJain01 YashviJain01 requested a review from Dmaddu December 11, 2024 09:27
@Dmaddu Dmaddu merged commit b7dc64b into CHEF-5668 Dec 12, 2024
10 of 13 checks passed
@Dmaddu Dmaddu deleted the sanju/remove_pg_password_from_a2_platform_file branch December 12, 2024 03:50
jashaik pushed a commit that referenced this pull request Dec 31, 2024
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
RoyShravani pushed a commit that referenced this pull request Jan 31, 2025
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
SanjuPal01 added a commit that referenced this pull request Feb 4, 2025
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
SanjuPal01 added a commit that referenced this pull request Feb 6, 2025
* Storing password in secret helper

Signed-off-by: “SanjuPal01” <[email protected]>

* Adding Dex Component Changes

Signed-off-by: “SanjuPal01” <[email protected]>

* Reading password from secret helper in notification-service

Signed-off-by: “SanjuPal01” <[email protected]>

---------

Signed-off-by: “SanjuPal01” <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants