[CI] Start shellchecking some scripts #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a LOT of bash and shell in this repository. shellcheck can help catch errors and other shell gotcha's. This PR gets us started by applying it to one small set of files. Signed-off-by: Steven Danna <[email protected]>
srenatus
approved these changes
Jul 2, 2019
| @@ -18,8 +18,8 @@ HAB_VERSION=$HAB_SUP_VERSION | |||
| HAB_RELEASE=$(curl "https://bldr.habitat.sh/v1/depot/channels/core/stable/pkgs/hab/$HAB_VERSION/latest" | jq -r .ident.release) | |||
|
|
|||
| HAB_LAUNCH_IDENT_JSON=$(curl "https://bldr.habitat.sh/v1/depot/channels/core/stable/pkgs/hab-launcher/latest" | jq -r .ident) | |||
| HAB_LAUNCH_VERSION=$(echo $HAB_LAUNCH_IDENT_JSON | jq -r .version) | |||
| HAB_LAUNCH_RELEASE=$(echo $HAB_LAUNCH_IDENT_JSON | jq -r .release) | |||
| HAB_LAUNCH_VERSION=$(echo "$HAB_LAUNCH_IDENT_JSON" | jq -r .version) | |||
There was a problem hiding this comment.
[bikeshed] I prefer args, like,
Suggested change
| HAB_LAUNCH_VERSION=$(echo "$HAB_LAUNCH_IDENT_JSON" | jq -r .version) | |
| HAB_LAUNCH_VERSION=$(jq -nr --argjson ident "$HAB_LAUNCH_IDENT_JSON" '$ident.version') |
But it might be overkill and at any rate, out-of-scope for this PR.
There was a problem hiding this comment.
I like this too (having just learned of it this morning), but I'm gonna leave it out here since these are all more or less mechanical corrections.
| @@ -2,11 +2,11 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| echo "Install latest dep" | |||
| echo "Install latest dep and other tools" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a LOT of bash and shell in this repository. shellcheck can
help catch errors and other shell gotcha's. This PR gets us started by
applying it to one small set of files.
Signed-off-by: Steven Danna [email protected]