automate-ui: cleanup statusText usage #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
force-pushed
the
sr/automate-ui/cleanup-usage-of-statusText
branch
2 times, most recently
from
dcf9653 to
237e789
Compare
tylercloke
approved these changes
Jun 27, 2019
msorens
reviewed
Jun 27, 2019
There was a problem hiding this comment.
I believe the fix applied in telemetry.service.ts also needs to be applied here:
(1) telemetry.service.ts::L262
console.log(`Error emitting telemetry event: ${error.status} - ${error.statusText}`);
(2) reset_password.component.ts::L53
error.status ? `${error.status} - ${error.statusText}` : 'Server error';
|
|
- removed from test specs where it didn't matter
- replaced with error.message where it did matter
- placed a comment on it where I didn't want to change anything
What is this? HTTP/2 doesn't send a "status text". Status text is the last segment after
HTTP/x.y <CODE> <REASON>
in the server response, so, where with HTTP/1.1 we see
HTTP/1.1 401 Unauthorized
with HTTP/2, we see
HTTP/2 401
The corresponding RFC7540 paragraph is [1]:
> HTTP/2 does not define a way to carry the version or reason phrase that is included in an HTTP/1.1 status line.
[1]: https://greenbytes.de/tech/webdav/rfc7540.html#rfc.section.8.1.2.4.p.2
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/automate-ui/cleanup-usage-of-statusText
branch
from
237e789 to
826c862
Compare
|
WMWG (will merge when green) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this? HTTP/2 doesn't send a "status text". Status text is the last segment after
in the server response, so, where with HTTP/1.1 we see
with HTTP/2, we see
The corresponding RFC7540 paragraph is