Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: deleting elasticsearch documents at end of test #681

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Flaky test: deleting elasticsearch documents at end of test #681

merged 1 commit into from
Jul 1, 2019

Conversation

lancewf
Copy link
Contributor

@lancewf lancewf commented Jun 25, 2019 •
edited
Loading

🔩 Description

Retrying failed attempts at deleting all elasticsearch documents.

⛓️ Related Resources

#613

✅ Checklist

  • Necessary tests added/updated?
  • Necessary docs added/updated?
  • Code actually executed?
  • Vetting performed (unit tests, lint, etc.)?

Retrying cleaning up elasticsearch
986ec35 
Signed-off-by: Lance Finfrock <[email protected]>
@lancewf lancewf added the WIP label Jun 25, 2019
@phiggins
Copy link
Contributor

In the past when I've had integration tests that ran against a live elasticsearch instance, instead of deleting the documents I'd delete and recreate the indexes. I looked into this a bit before to try to fix these flaky test errors but I couldn't figure out where all the index creation happened.

@lancewf
Copy link
Contributor Author

lancewf commented Jun 25, 2019

Thank @phiggins I will try that out.

@lancewf lancewf added the compliance reporting This issue or pull request applies to the compliance reporting part of Automate label Jun 27, 2019
@lancewf
Copy link
Contributor Author

lancewf commented Jul 1, 2019

I feel deleting and recreating the indexes after every test is a little too much. I want to go with retrying deleting the documents for now.

@lancewf lancewf changed the title WIP: Flaky test: deleting elasticsearch documents at end of test Flaky test: deleting elasticsearch documents at end of test Jul 1, 2019
@lancewf lancewf requested a review from a team July 1, 2019 17:33
@lancewf lancewf removed the WIP label Jul 1, 2019
@lancewf lancewf merged commit 2dbd0a3 into master Jul 1, 2019
@chef-ci chef-ci deleted the lancewf/flaky_test_fix branch July 1, 2019 17:37
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2021
Open
@ekmixon ekmixon mentioned this pull request May 17, 2022
Open
@ekmixon ekmixon mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjeffrey vjeffrey vjeffrey approved these changes

Assignees
No one assigned
Labels
compliance reporting This issue or pull request applies to the compliance reporting part of Automate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lancewf @phiggins @vjeffrey