Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra node details page UI #5071

Merged
merged 13 commits into from
May 18, 2021
Merged

Infra node details page UI #5071

merged 13 commits into from
May 18, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented May 14, 2021

🔩 Description: What code changed, and why?

we need to create the UI for the infra server node details page, also we need to show the available tags with add/remove tags functionality and update the environment functionality.

⛓️ Related Resources

#4548

👍 Definition of Done

I have added the below changes to the node details page.

  • show node details
  • update environment
  • add tags functionality
  • remove functionality
  • Cypress specs

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/chef-servers`
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the -->  `infrastructure tab` from the top navigation bar then you can see the `Chef Infra Server`
If you have data then you can see the list of servers 
--> then click to any of the servers --> see the list of org's
--> click to any of org ---> you can see the multiple tabs --> default tab is cookbooks tab 
--> you can see the nodes tab ---> click to nodes tab
--> if nodes are available then you can see the list of nodes.
--> click to any of nodes then you can redirect to the node details page.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

node-details.mp4

@netlify
Copy link

netlify bot commented May 14, 2021

Deploy preview for chef-automate processing.

Building with commit 670ef7a

https://app.netlify.com/sites/chef-automate/deploys/60a338d44f26cb0007739bf4

@@ -0,0 +1,305 @@
@import "~styles/variables";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comments in this file 🎉

Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 🎉

Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @vinay033

@vinay033 vinay033 force-pushed the Vinay/node_details_page branch from f806dd8 to 08228b4 Compare May 17, 2021 13:33
@kalroy kalroy force-pushed the Vinay/node_details_page branch from 08228b4 to 670ef7a Compare May 18, 2021 03:47
@kalroy kalroy merged commit f725412 into master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants