-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infra node details page UI #5071
Conversation
Deploy preview for chef-automate processing. Building with commit 670ef7a https://app.netlify.com/sites/chef-automate/deploys/60a338d44f26cb0007739bf4 |
components/automate-ui/src/app/entities/infra-nodes/infra-nodes.reducer.ts
Outdated
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Show resolved
Hide resolved
...automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.html
Show resolved
Hide resolved
@@ -0,0 +1,305 @@ | |||
@import "~styles/variables"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the comments in this file 🎉
...omate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.spec.ts
Outdated
Show resolved
Hide resolved
...s/automate-ui/src/app/modules/infra-proxy/infra-node-details/infra-node-details.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @vinay033
f806dd8
to
08228b4
Compare
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
08228b4
to
670ef7a
Compare
🔩 Description: What code changed, and why?
we need to create the UI for the infra server node details page, also we need to show the available tags with add/remove tags functionality and update the environment functionality.
⛓️ Related Resources
#4548
👍 Definition of Done
I have added the below changes to the node details page.
👟 How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
node-details.mp4