Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not obscure problems in response, ignore SSL #5070

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Do not obscure problems in response, ignore SSL #5070

merged 4 commits into from
Jan 18, 2022

Conversation

sean-horn
Copy link
Contributor

-s can obscure failures in the curl run.
-k should be used to avoid ssl verify for internal commands

Signed-off-by: Sean Horn [email protected]

🔩 Description: What code changed, and why?

N/A

⛓️ Related Resources

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

Docs changes only

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented May 14, 2021

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: f9946d3

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61e71ffb5041610007da1bae

😎 Browse the preview: https://deploy-preview-5070--chef-automate.netlify.app

sean-horn and others added 3 commits August 13, 2021 10:29
-s can obscure failures in the curl run.
-k should be used to avoid ssl verify for internal commands

Signed-off-by: Sean Horn <[email protected]>
Avoid progress, include errors, no verify. Thanks, @tg

Signed-off-by: Sean horn <[email protected]>
Signed-off-by: kagarmoe <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

```bash
curl -s -H "api-token: $TOKEN" https://{{< example_fqdn "automate" >}}/api/v0/data-lifecycle/status
curl -s -S -k -H "api-token: $TOKEN" https://{{< example_fqdn "automate" >}}/api/v0/data-lifecycle/status
Copy link

@kagarmoe kagarmoe Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this curl is silent but shows errors

-s -S doesn't show progress meter but shows errors

@sean-horn sean-horn requested a review from a team as a code owner January 18, 2022 20:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants