-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the description column on environment tab #4722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for chef-automate ready! Built with commit 0052164 |
495d1c6
to
416ccb8
Compare
kalroy
requested changes
Feb 15, 2021
components/automate-ui/src/app/modules/infra-proxy/environments/environments.component.html
Outdated
Show resolved
Hide resolved
shaik80
approved these changes
Feb 15, 2021
👟 How to Build and Test the Change |
416ccb8
to
7364b7a
Compare
Signed-off-by: Vinay Sharma <[email protected]>
Signed-off-by: Vinay Sharma <[email protected]>
7364b7a
to
c1cd21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vinay Sharma [email protected]
🔩 Description: What code changed, and why?
we need to add a description column on the infra proxy environment tab.
⛓️ Related Resources
#4721
👍 Definition of Done
I have added changes to show the description column on the environment tab
ℹ️ Note
This PR is not containing the new design CSS, it depends on PR: #4673
after merging the dependent PR this page show like same as the attached screenshot.
👟 How to Build and Test the Change
Steps to reproduce the behavior:
if you have sample data for the infra servers than
go to >> infrastructure tab >> click on Chef server on left side navigation bar >> Organizations >> Environments tab >> see the list of environments.
✅ Checklist
📷 Screenshots, if applicable