Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the description column on environment tab #4722

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

vinay033
Copy link
Collaborator

Signed-off-by: Vinay Sharma [email protected]

🔩 Description: What code changed, and why?

we need to add a description column on the infra proxy environment tab.

needDesc

⛓️ Related Resources

#4721

👍 Definition of Done

I have added changes to show the description column on the environment tab

ℹ️ Note

This PR is not containing the new design CSS, it depends on PR: #4673
after merging the dependent PR this page show like same as the attached screenshot.

👟 How to Build and Test the Change

Steps to reproduce the behavior:
if you have sample data for the infra servers than
go to >> infrastructure tab >> click on Chef server on left side navigation bar >> Organizations >> Environments tab >> see the list of environments.

✅ Checklist

📷 Screenshots, if applicable

Description

@netlify
Copy link

netlify bot commented Feb 12, 2021

Deploy preview for chef-automate ready!

Built with commit 0052164

https://deploy-preview-4722--chef-automate.netlify.app

@shaik80
Copy link
Member

shaik80 commented Feb 12, 2021

Screenshot 2021-02-12 at 5 40 37 PM

Not able to view description data tried to rebuild infra-proxy-service getting the same result to me

@vinay033
Copy link
Collaborator Author

Screenshot 2021-02-12 at 5 40 37 PM

Not able to view description data tried to rebuild infra-proxy-service getting the same result to me

have you checked on manage, if manage has a description available for a particular environment then the same data reflecting on automate.

@kalroy kalroy requested review from kalroy and removed request for kalroy February 12, 2021 17:11
@kalroy kalroy force-pushed the Vinay/add_description_column_to_env_tab branch from 495d1c6 to 416ccb8 Compare February 15, 2021 01:16
@shaik80
Copy link
Member

shaik80 commented Feb 15, 2021

👟 How to Build and Test the Change
Need to rebuild gateway, infra-proxy, UI, before testing UI changes

@vinay033 vinay033 force-pushed the Vinay/add_description_column_to_env_tab branch from 416ccb8 to 7364b7a Compare February 15, 2021 10:07
@vinay033 vinay033 force-pushed the Vinay/add_description_column_to_env_tab branch from 7364b7a to c1cd21c Compare February 15, 2021 10:08
@kalroy kalroy merged commit e903cca into master Feb 17, 2021
@kalroy kalroy deleted the Vinay/add_description_column_to_env_tab branch February 17, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants