-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic spelling sweep #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
approved these changes
May 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -181,7 +181,7 @@ handle_metadata({ok, IdPMetadata}, SSOBinding, NameId) -> | |||
handle_return([], _) -> {error, not_found}; | |||
handle_return([Config], EntName) -> {ok, deserialize(Config, EntName)}; | |||
handle_return({error, Why}, _) -> | |||
chef_log:error("An internal server error occured in trying to perform a db operation on SAML configuration. ~n~p", [Why]), | |||
chef_log:error("An internal server error occurred in trying to perform a db operation on SAML configuration. ~n~p", [Why]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how dare you
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Signed-off-by: michael sorens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
This is a periodic sweep of spelling corrections and exceptions across Automate.
As there are a few new components there is a larger swath of files in this PR.
This is generated by running
./scripts/spellcheck
from the automate repo root.(Eventually the spell checker will be wired up to the build itself, but have not gotten to that yet.)
👍 Definition of Done
Almost all spelling errors resolved.
👟 Demo Script / Repro Steps
⛓️ Related Resources
✅ Checklist