remove node state link from client run page #404
Conversation
| @@ -4,7 +4,7 @@ | |||
| </div> | |||
|
|
|||
| <app-server-org-filter-sidebar> | |||
| <chef-sidebar-entry route="/client-runs" icon="storage">Node State</chef-sidebar-entry> | |||
| <!-- <chef-sidebar-entry route="/client-runs" icon="storage">Node State</chef-sidebar-entry> --> | |||
There was a problem hiding this comment.
[nit] I'd rather just delete the line. git doesn't forget 😉
There was a problem hiding this comment.
i think you might be able to pull out the whole nav too, and not just that one entry.
There was a problem hiding this comment.
@srenatus I have removed the commented line. :)
There was a problem hiding this comment.
I'd merge, but I'm not sure I fully follow you there, @susanev: which whole nav would you like to see pulled?
There was a problem hiding this comment.
yah, sorry i was not being clear. right now it renders a totally empty nav element when there are no items in the left-nav. i realize now, that workflow complicates things. the empty nav element can be annoying for people using screen readers. but its not important enough to fix in this pr i dont think. so ignore my comment, heh.
Signed-off-by: vinay033 <[email protected]>
Signed-off-by: vinay033 <[email protected]>
vinay033
force-pushed
the
Vinay/MSYS-1038_Remove_node_state_link_from_client_runs
branch
from
823f594 to
71dcc5c
Compare
chef-ci
deleted the
Vinay/MSYS-1038_Remove_node_state_link_from_client_runs
branch
Signed-off-by: vinay033 [email protected]
🔩 Description
During usability studies at ChefConf 2019 participants repeatedly clicked on the Node State link on the Client Runs page expecting something to happen. This task removes that link if we add more items to the left-nav of that page in the future we can add it back.
After talking with @jonong1972 this task is only removing the link from the Client Runs landing page, it will still be visible on node detail pages, we can revisit that in the future if necessary.
👍 Definition of Done
⛓️ Related Resources
Fixes #397