Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated toggle sort in Notification table. #3978

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Conversation

samshinde
Copy link
Contributor

@samshinde samshinde commented Jun 25, 2020

🔩 Description: What code changed, and why?

Before it being used as up/down, which then sets the toggles arrows out of sync with the actual sort direction. So Updated the code and added default case scenario in Notification list table.

⛓️ Related Resources

#3837

👍 Definition of Done

Updated The toggle arrows to stay in sync with the sort direction.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

$npm run serve:hab
  1. git fetch origin Amol/chef_sort_toggle
  2. build components/automate-ui [Above steps for reference.]
  3. Go to Settings tab >> Notification Tab.
  4. Click on Notification list >> Create Notification >> Add notifications
  5. Click on Sort arrows for 3 scenario : asc/des/default.

✅ Checklist

📷 Screenshots, if applicable

arrow-issue-resolved

@susanev susanev requested a review from a team June 26, 2020 15:05
Copy link
Contributor

@tarablack01 tarablack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@tarablack01 tarablack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants