Fix bug where css variable nesting was broken #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylercloke
changed the title
tylercloke
force-pushed
the
tc/fix-nested-css-var-overrides
branch
2 times, most recently
from
2c28756 to
1c1bcd6
Compare
…-hsla references This commit 58632b3#diff-c206cc432a36a0164b93bff1503dc802L30 accidentally changed css variable nesting incorrectly in a few spots from this: var(--non-default, var(--default)) To this improper format: var(--non-default), var(--default) I've fixed it in all the places I found in that commit. Signed-off-by: Tyler Cloke <[email protected]>
tylercloke
force-pushed
the
tc/fix-nested-css-var-overrides
branch
from
1c1bcd6 to
bc93f3f
Compare
msorens
approved these changes
May 17, 2019
susanev
approved these changes
May 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
This commit 58632b3#diff-c206cc432a36a0164b93bff1503dc802L30 accidentally changed css variable nesting incorrectly in a few spots from this:
var(--non-default, var(--default));To this improper format:
var(--non-default), var(--default);I've fixed it in all the places I found in that commit.
⛓️ Related Resources
✅ Checklist