Adding project filters for NodeExport #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lancewf
force-pushed
the
lancewf/project_filter_NodeExport
branch
from
827599c to
d3f54b4
Compare
lancewf
changed the title
lancewf
added
iamv2
Signed-off-by: Lance Finfrock <[email protected]>
lancewf
force-pushed
the
lancewf/project_filter_NodeExport
branch
from
d3f54b4 to
1935d55
Compare
phiggins
reviewed
May 17, 2019
| actualNodeNames = append(actualNodeNames, nodeName) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
I'm not sure I understand this part. Do we not have a type for the response returned here?
There was a problem hiding this comment.
We do not have an exposed type. The type is here https://github.com/chef/automate/blob/master/components/config-mgmt-service/grpcserver/node_export.go#L31.
I found it easier to just parse the JSON.
phiggins
reviewed
May 17, 2019
|
|
||
| actualNodeNames := make([]string, 0) | ||
| jsonparser.ArrayEach(data, func(node []byte, _ jsonparser.ValueType, _ int, err error) { | ||
| if err == nil { |
There was a problem hiding this comment.
I know this test is not trying to verify basic correctness of the endpoint, but it feels bad to ignore errors here...
There was a problem hiding this comment.
That sounds right. I will update this test to fail on a returned error.
phiggins
approved these changes
May 17, 2019
Signed-off-by: Lance Finfrock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
Adding project filtering for the cfgmgmt.proto NodeExport RPCs.
⛓️ Related Resources
#68
✅ Checklist