nodes: filtering by multiple tags #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2019 16:36
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
Signed-off-by: Victoria Jeffrey <[email protected]>
vjeffrey
commented
May 17, 2019
| if len(oRConditionsForTags) == 0 { | ||
| whereFilter = fmt.Sprintf("WHERE (%s)", strings.Join(conditions, " AND ")) | ||
| } else { | ||
| if len(conditions) > 0 { |
There was a problem hiding this comment.
is this too messy? is there a cleaner way?
There was a problem hiding this comment.
The logic is getting a bit convoluted with special cases. I think you could simplify somewhat by separating all the tag handling from the other filters. If you moved all the tag filter handling first, that stuff could be ORed together and added to the conditions as just another element, since those all get ANDed together at the end.
Hopefully that made sense, I was trying to avoid just writing a bunch of pseudocode.
Signed-off-by: Victoria Jeffrey <[email protected]>
vjeffrey
force-pushed
the
vj/filter-mult-tags
branch
from
1d3def8 to
234a876
Compare
phiggins
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
fixes #370
When creating a scan job, and filtering by tag values for the Automate node manager, we are currently unable to filter by multiple tags.
👍 Definition of Done
Able to filter nodes by multiple tags (Automate nodemanager)
👟 Demo Script / Repro Steps
rebuild nodemanager
create some nodes with different tags
create a scan job filtering by those tags