automate-3081 ui flicker on applications tab #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarablack01
requested review from
stevendanna,
Shadae,
SEAjamieD and
scottopherson
susanev
approved these changes
May 18, 2020
SEAjamieD
reviewed
May 19, 2020
There was a problem hiding this comment.
I noticed this is working great for the main portion of the application 👍.
While testing I noticed that it appears that the Services sidebar is having the same issue. Interesting since it doesn't appear to be happening in the video from #3081
|
@SEAjamieD thanks for catching that bug! I'll fix it 👍🏻 |
msorens
suggested changes
May 28, 2020
components/automate-ui/src/app/pages/service-groups/service-groups.component.ts
Outdated
Show resolved
Hide resolved
tarablack01
force-pushed
the
automate-3081
branch
from
ac74148 to
8def652
Compare
msorens
approved these changes
May 28, 2020
components/automate-ui/src/app/pages/service-groups/service-groups.component.ts
Outdated
Show resolved
Hide resolved
tarablack01
force-pushed
the
automate-3081
branch
from
8def652 to
4013769
Compare
scottopherson
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
When moving between "OK" and "Disconnected" nodes, the UI moves from the loading spinner, to the old data, to the new data, with a visible redraw when the new data is finally shown.
⛓️ Related Resources
fixes #3081
👍 Definition of Done
Smooth as butter, no flicker.
👟 How to Build and Test the Change
hab studio enter
export DEVPROXY_URL=localhost
build components/automate-ui-devproxy
start_automate_ui_background
start_all_services
applications_populate_database
Steps to reproduce the behavior:
Go to Application Tab
Select "OK" filter
Select "Disconnected" filter.
Note I am very far from this A2 server, so high-network latency may help reproduce it.
✅ Checklist
📷 Screenshots, if applicable