-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra-proxy-service] Add environments & expanded_run_lists attributes in Roles API #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvivek1115
commented
Mar 30, 2020
go.sum
Outdated
@@ -68,8 +68,8 @@ github.com/census-ecosystem/opencensus-go-exporter-aws v0.0.0-20180411051634-416 | |||
github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU= | |||
github.com/cespare/xxhash/v2 v2.1.1 h1:6MnRN8NT7+YBpUIWxHtefFZOKTAPgGjpQSxqLNn0+qY= | |||
github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= | |||
github.com/chef/go-chef v0.3.1-0.20191115205148-7ac24fba7a27 h1:zb1dtm/zUcVrxyDd50XtovQFSQa26y2jJt2Dt7IzDQQ= | |||
github.com/chef/go-chef v0.3.1-0.20191115205148-7ac24fba7a27/go.mod h1:ft8oU7s0ktse9xzZO4n8wxTz6EKx+V+fuhYxktqXvG8= | |||
github.com/chef/go-chef v0.4.1-0.20200328065122-dfce3c0d2dc7 h1:+MU0TcZz3tfQTYEo2RwWe7AmaYkL7RB83KPcNsEXJTk= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the go-chef lib to pull the latest changes and apply make revendor
b3900f5
to
c17503c
Compare
kvivek1115
commented
Mar 31, 2020
return &response.DataBags{ | ||
DataBags: fromAPIToListDatabags(*dataBags), | ||
}, nil | ||
dataBags, err := client.DataBags.List() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observed minor cleanup to skip else
if if
have return
statements.
… list API Signed-off-by: Vivek Singh <[email protected]>
- Update the go-chef lib. - Add environment base runlist and expand the runlist. Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
- update the go-chef lib with latest master - go get -u github.com/chef/go-chef@master Signed-off-by: Vivek Singh <[email protected]>
85572ea
to
7aa99e4
Compare
vjeffrey
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
description
,environments
attributes in Roles list API.default_attributes
,override_attributes
andexpanded_run_list
attributes in role detail API.⛓️ Related Resources
#1544

Mock UI Ref:
👍 Definition of Done
name
, description, and environments.default_attributes
,override_attributes
andexpanded_run_list
.👟 How to Build and Test the Change
Steps to build:
rebuild components/infra-proxy-service
rebuild components/automate-gateway
Steps to test:
gPRC GetRoles API:
HTTP GetRoles API:
Response:
gPRC GetRole API:
HTTP GetRole API:
Response:
✅ Checklist
📷 Screenshots, if applicable