-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dan/top infra errors #3195
Dan/top infra errors #3195
Conversation
d4f5e25
to
c03071f
Compare
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
Signed-off-by: Daniel DeLeo <[email protected]>
c03071f
to
677d82d
Compare
message Errors { | ||
// The number of results to return. | ||
// If set to zero, the default size of 10 will be used. Set to a negative | ||
// value for unlimited results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️
// }, | ||
// "aggs": { | ||
// "group_by_error_type_and_message": { | ||
// "composite": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THANK YOU for all the descriptive comments, this is awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️ thank you!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested this and got through most of the code.
🔩 Description: What code changed, and why?
API for the top Chef Infra errors. Aggregates the most common error by class+message among the most recent chef runs across the fleet. The nodes considered in the aggregation can be filtered with the same filters as other node APIs (except
status
is not allowed because the aggregation only considers nodes with "failed" status).⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
Generating usable test data is most easily done with the changes in #3213 -- the instructions here assume that's merged or you make a combo branch or get those changes some other way.
source .studio/automate-gateway
-- this is used for the data generation step.curl -f --insecure -H "api-token: $(get_admin_token)" "$GATEWAY_URL/cfgmgmt/errors" | jq .
✅ Checklist