Make ES gateway timeouts configurable #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmdarroch
approved these changes
Mar 24, 2020
ryancragun
reviewed
Mar 24, 2020
| @@ -68,6 +68,8 @@ message ConfigRequest { | |||
| google.protobuf.Int32Value ssl_verify_depth = 15; | |||
| google.protobuf.Int32Value server_names_hash_bucket_size = 16; | |||
| google.protobuf.StringValue client_body_buffer_size = 17; | |||
| google.protobuf.Int32Value proxy_read_timeout = 18; | |||
| google.protobuf.Int32Value proxy_timeout_timeout = 19; | |||
There was a problem hiding this comment.
Suggested change
| google.protobuf.Int32Value proxy_timeout_timeout = 19; | |
| google.protobuf.Int32Value proxy_send_timeout = 19; |
yzl
approved these changes
Mar 24, 2020
stevendanna
reviewed
Mar 24, 2020
S3 operations get really slow with many backups / daily indexes. We've seen a delete exceed the hard coded default of 5 mins, and cause gateway timeouts. This changes the default to 10 mins and makes the timeouts configurable Signed-off-by: Jay Mundrawala <[email protected]>
jaym
force-pushed
the
jdm/es-gateway-config
branch
from
f20e50f to
b299e8a
Compare
stevendanna
approved these changes
Mar 25, 2020
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 operations get really slow with many backups / daily indexes.
We've seen a delete exceed the hard coded default of 5 mins, and
cause gateway timeouts.
This changes the default to 10 mins and makes the timeouts configurable