Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IAM Actions doc #3157

Merged
merged 10 commits into from
Apr 28, 2020
Merged

Adding IAM Actions doc #3157

merged 10 commits into from
Apr 28, 2020

Conversation

mjingle
Copy link
Contributor

@mjingle mjingle commented Mar 19, 2020

Signed-off-by: Mary Jinglewski [email protected]

🔩 Description: What code changed, and why?

To meet a documentation need for support and customers, we're adding a chart of IAM Actions, their end points, and their associated UI page to the Chef Automate docs site.

Related Resources

https://github.com/chef/release-engineering/issues/1064

👍 Definition of Done

PR should be done when the details of this current chart are filled out as much as possible. @mjingle still needs to do a second run-through.

👟 How to Build and Test the Change

To view the docs change, pull in this PR and follow the instructions for make serve.

✅ Checklist

@mjingle mjingle added WIP documentation Anything related to the Automate docs. labels Mar 19, 2020
@mjingle mjingle requested a review from a team as a code owner March 19, 2020 18:25
@mjingle mjingle self-assigned this Mar 19, 2020
Copy link
Contributor

@susanev susanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope these comments are helpful!

@mjingle mjingle requested a review from kagarmoe March 20, 2020 20:15
@kagarmoe
Copy link

see rel-eng #1064

@susanev susanev added the auth-team anything that needs to be on the auth team board label Mar 27, 2020
| View Events | Dashboards | event:* | /event_feed | https://{{< example_fqdn "automate" >}}/dashboards/event-feed |
| View Service Group Data | Applications | applications:* | /applications/service-groups | https://{{< example_fqdn "automate" >}}/applications/service-groups |
| View Client Runs | Infrastructure | infra:nodes:* | /cfgmgmt/nodes | https://{{< example_fqdn "automate" >}}/infrastructure/client-runs |
| Manage Chef Servers | Infrastructure | infra:servers:* | <endpoint> | https://{{< example_fqdn "automate" >}}/infrastructure/chef-servers |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently under a feature flag. API details not developed yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weve got a product named manage, wonder if the use of this word might confuse folks?

Copy link

@kagarmoe kagarmoe Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Let's see if we can find a good synonym for "Manage".

Copy link
Contributor Author

@mjingle mjingle Apr 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for this page in the browser says "Manage Chef Servers with Chef Automate," but context is really important. Thank you @susanev for catching that.

Would "View Chef Servers" work instead in the meantime? I'm basing this on how Client Runs has "View Client Runs" and Client Runs is listed with Chef Servers in the same Infrastructure section.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cant edit anything for chef servers right now, so i think view works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but my comment was about the use of manage across this page, not just here for chef servers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're exploring this more, but I'm not sure that we can give up the word 'manage'--which accurately denotes the API actions-- because of the (deprecated) existence of Chef Manage. Changing some to add or edit X and keeping manage on those things that have parity with Chef Manage is also confusing for users.

@mjingle mjingle requested a review from susanev April 21, 2020 20:18
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good! When you have to choose between hewing closer to the headings or the page content, the preference should be towards the header. The exception, of course, is if the information in the page content is vital. In that case, we should look first at revising the header.

@mjingle mjingle force-pushed the mj/ChartingTasks branch 3 times, most recently from 2cd7dbc to 45d5d89 Compare April 27, 2020 20:16
| View Chef Servers | Infrastructure | infra:servers:* | <endpoint> | https://{{< example_fqdn "automate" >}}/infrastructure/chef-servers |
| List Reports | Compliance | compliance:reporting:* | /compliance/reporting/reports | https://{{< example_fqdn "automate" >}}/compliance/reports/overview |
| List Scan Jobs | Compliance | compliance:scannerJobs:* | /compliance/scanner/jobs | https://{{< example_fqdn "automate" >}}/compliance/scan-jobs/jobs |
| Add or Edit Scan Jobs | Compliance | [compliance:scannerJobs:* , infra:nodes:* , infra:nodeManagers:* , compliance:profiles:* ] | /compliance/scanner/jobs | https://{{< example_fqdn "automate" >}}/compliance/scan-jobs/jobs |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susanev How does this change through the document look?

Copy link
Contributor

@susanev susanev Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the * gives list, get, create, delete permissions so i think its a bit misleading, but i also understand yall are trying to highlight what is currently possible. so mixed feelings i guess. i would not try and block this from merging though. we could try this out and see if we get user feedback and adjust from there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why we prefer 'manage'; it implies the whole scope of actions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so they would all say manage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything from line 28 to line 40 would say "manage" rather than "add or edit" in this case.

@mjingle mjingle requested a review from kagarmoe April 28, 2020 19:59
@mjingle mjingle removed the WIP label Apr 28, 2020
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-121789253

Mary Jinglewski added 5 commits April 28, 2020 16:22
Signed-off-by: Mary Jinglewski <[email protected]>
Signed-off-by: Mary Jinglewski <[email protected]>
Signed-off-by: Mary Jinglewski <[email protected]>
Signed-off-by: Mary Jinglewski <[email protected]>
Mary Jinglewski added 3 commits April 28, 2020 16:22
Signed-off-by: Mary Jinglewski <[email protected]>
Signed-off-by: Mary Jinglewski <[email protected]>
Mary Jinglewski added 2 commits April 28, 2020 16:27
Signed-off-by: Mary Jinglewski <[email protected]>
Signed-off-by: Mary Jinglewski <[email protected]>
@susanev susanev merged commit 714fafd into master Apr 28, 2020
@chef-expeditor chef-expeditor bot deleted the mj/ChartingTasks branch April 28, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-team anything that needs to be on the auth team board documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants