Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api docs: secrets service #3113

Merged
merged 2 commits into from
Mar 17, 2020
Merged

api docs: secrets service #3113

merged 2 commits into from
Mar 17, 2020

Conversation

vjeffrey
Copy link

🔩 Description: What code changed, and why?

documenting the secrets service

⛓️ Related Resources

#2357

👍 Definition of Done

secrets service is documented!

👟 How to Build and Test the Change

check out the branch
run make serve from components/automate-chef-io
http://localhost:1313/docs/api/

✅ Checklist

Signed-off-by: Victoria Jeffrey <[email protected]>
@vjeffrey vjeffrey requested a review from a team as a code owner March 16, 2020 22:20
@vjeffrey vjeffrey changed the title Vj/secrets proto docs api docs: secrets service Mar 16, 2020
@vjeffrey vjeffrey added the documentation Anything related to the Automate docs. label Mar 16, 2020
@vjeffrey vjeffrey force-pushed the vj/secrets-proto-docs branch from 2b2dd2a to e1b41ab Compare March 17, 2020 19:45
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge before it breaks again!
tenor-161801152

@kagarmoe kagarmoe merged commit 3310af2 into master Mar 17, 2020
@chef-expeditor chef-expeditor bot deleted the vj/secrets-proto-docs branch March 17, 2020 21:53
kagarmoe pushed a commit that referenced this pull request Mar 17, 2020
* document the secrets service (proto)

Signed-off-by: Victoria Jeffrey <[email protected]>

* other changes that appeared after compiling protos

Signed-off-by: Victoria Jeffrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants