bugfix: ensure node name is correctly assigned when running ssm scan #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n ssm nodes Signed-off-by: Victoria Jeffrey <[email protected]>
stevendanna
approved these changes
Mar 17, 2020
| @@ -485,17 +485,28 @@ func (r *Resolver) handleAzureVmNodes(ctx context.Context, m *manager.NodeManage | |||
| return r.handleManagerNodes(ctx, m, nodeCollections, job) | |||
| } | |||
|
|
|||
| func (r *Resolver) handleInstanceCredentials(ctx context.Context, instanceCreds []*manager.CredentialsByTags, node *manager.ManagerNode) ([]*inspec.Secrets, nodeInfo) { | |||
| var nodeInfo nodeInfo | |||
| func handleNodeInfo(node *manager.ManagerNode) nodeInfo { | |||
There was a problem hiding this comment.
I know we use handle in many of the other function names, but I'm wondering if nodeInfoFromManagerNode would be a more clear name?
Signed-off-by: Victoria Jeffrey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
I noticed there was a bug with ssm jobs during some acceptance testing -- all nodes showed up nameless after an ssm scan.
Figured out we had some faulty logic in resolver.go -- we were looking for a key value to determine the name and completely ignoring the name of the instance as we had discovered it.
This code change fixes that!
⛓️ Related Resources
#2640
👍 Definition of Done
Cloud scans of ec2 result in nodes with names!
👟 How to Build and Test the Change
rebuild compliance
run an ssm scan of the nodes (via aws or azure)
✅ Checklist