Add styles to labels in scan jobs form #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seajamied <[email protected]>
SEAjamieD
added
automate-ui
layout
susanev
approved these changes
Nov 22, 2019
kagarmoe
pushed a commit
that referenced
this pull request
Nov 23, 2019
Signed-off-by: seajamied <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
The styling in https://a2-local-inplace-upgrade-dev.cd.chef.co/jobs/add is out of wack in the
Add Nodesportion of the form. Specifically elements are laid out inline. Turned out that the styling for the labels was missing. I've replaced the label styling and now they are back to normal.⛓️ Related Resources
fixes #2240
👍 Definition of Done
Form elements are stacking on top of each other, as they are in acceptance.
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable
Dev - broken
Acceptance - correct
This Branch
