gateway: quick fix for mockgen Make targets #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a chicken-and-egg problem that we hit when trying to add a
service since the package the code-generator reflects on also requires
that the generated code is already correctly generated.
Note the change in clients_mock.go is likely from the fact that this
file was hand-edited in the past.
I've also removed a Make target which simply didn't work because the
relevant files didn't exist.
Further, I noticed that running `make` produces files in
mock_compliance_events/
which are not currently in source control. I haven't added them here
as as I wasn't sure if this was intentional.
In short, mock generation is a big mess still and needs to be cleaned
up, but at least now `make` works again.
Signed-off-by: Steven Danna <[email protected]>
Signed-off-by: Vivek Singh <[email protected]>
2 tasks
jaym
approved these changes
Nov 13, 2019
yzl
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a chicken-and-egg problem that we hit when trying to add a
service since the package the code-generator reflects on also requires
that the generated code is already correctly generated.
Note the change in clients_mock.go is likely from the fact that this
file was hand-edited in the past.
I've also removed a Make target which simply didn't work because the
relevant files didn't exist.
Further, I noticed that running
makeproduces files inwhich are not currently in source control. I haven't added them here
as as I wasn't sure if this was intentional.
In short, mock generation is a big mess still and needs to be cleaned
up, but at least now
makeworks again.Signed-off-by: Steven Danna [email protected]
Signed-off-by: Vivek Singh [email protected]