Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deployment] Set HAB_LICENSE=accept-no-persist in a lot of places #207

Merged
merged 1 commit into from
May 13, 2019

Conversation

stevendanna
Copy link
Contributor

This is a first pass at making sure we are calling hab with
HAB_LICENSE=no-accept-persist

Because hab sup run also requires a license check currently we also
need to set this in our systemd unit file. Since that is inherited by
all processes in our process tree, we are probably OK if we missed a
hab call or two, but I would rather not depend on that. Further, right
now we don't correctly restart our systemd unit file in all cases, so
this likely won't take effect unless #90 is merged first.

Signed-off-by: Steven Danna [email protected]

This is a first pass at making sure we are calling hab with
HAB_LICENSE=no-accept-persist

Because `hab sup run` also requires a license check currently we also
need to set this in our systemd unit file. Since that is inherited by
all processes in our process tree, we are probably OK if we missed a
hab call or two, but I would rather not depend on that. Further, right
now we don't correctly restart our systemd unit file in all cases, so
this likely won't take effect unless #90 is merged first.

Signed-off-by: Steven Danna <[email protected]>
@stevendanna
Copy link
Contributor Author

This is mostly untested since I was trying trouble getting hab to build locally.

stevendanna added a commit that referenced this pull request May 13, 2019
The most recent habitat now requires license acceptance.

See also: #207

Signed-off-by: Steven Danna <[email protected]>
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Comparing the removed lines to the new lines, this looks good to me. Haven't pulled it down, and haven't checked for completeness.

@stevendanna stevendanna merged commit ed5a0fd into master May 13, 2019
@chef-ci chef-ci deleted the ssd/hab-license branch May 13, 2019 11:52
stevendanna added a commit that referenced this pull request May 13, 2019
The most recent habitat now requires license acceptance.

See also: #207

Signed-off-by: Steven Danna <[email protected]>
stevendanna added a commit that referenced this pull request May 14, 2019
The most recent habitat now requires license acceptance.

See also: #207

Signed-off-by: Steven Danna <[email protected]>
stevendanna added a commit that referenced this pull request May 14, 2019
The most recent habitat now requires license acceptance.

See also: #207

Signed-off-by: Steven Danna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants