deps: bump dex to v2.17.0 #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
added
auth-team
|
💥 l-u-s needs its mocks updated, and session-service revealed some go-oidc dependency issue -- we'll need to bump that, too, I suppose. |
- https://github.com/dexidp/dex/releases/tag/v2.16.0 - https://github.com/dexidp/dex/releases/tag/v2.17.0 Nothing immediately relevant for us, but why not stay up to date? Signed-off-by: Stephan Renatus <[email protected]>
We're using some vendored grpc client code in local-user-service. It's GRPC, and it doesn't really matter which release we're on, but let's keep these in sync nonetheless. Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/bump/dex-v2.17.0
branch
from
fa39410 to
e850145
Compare
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/bump/dex-v2.17.0
branch
from
e850145 to
f48513b
Compare
Signed-off-by: Stephan Renatus <[email protected]>
stevendanna
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
This looks reasonable to me. Hard to argue with -3k lines. The OIDCv2 changes were a bit too much to practically review, but I skimmed the code and to me the v2 branch looks higher quality than the v1 branch we were on, so I am not too worried about moving to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing immediately relevant for us, but why not stay up to date?
Also, the next release is going to include dexidp/dex#1486 which will let us simplify some code in local-user-service. Anticipating that, let's update now.
ℹ️ This pulls in
github.com/coreos/go-oidc@v2, as a dependency of Dex. This is a consequence of us using an in-memory dex server for testing, and thus having to eat its dependencies. You might argue that we should not have done that; but on the other hand, v2 of that library is what is maintained, and I do think we care about that. So, pulling this in is a good thing. 😃ℹ️ Also updates
golang.org/x/oauth2, because it's better to do that once in a while -- changes are here: golang/oauth2@0448841...0f29369