-
Notifications
You must be signed in to change notification settings - Fork 114
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Project filtering for reporting server ListReports endpoint.
- Loading branch information
Showing
3 changed files
with
200 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 181 additions & 0 deletions
181
components/compliance-service/integration_test/reporting_server_list_profiles_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| package integration_test | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
|
|
||
| authzConstants "github.com/chef/automate/components/authz-service/constants/v2" | ||
| "github.com/chef/automate/components/compliance-service/api/reporting" | ||
| reportingServer "github.com/chef/automate/components/compliance-service/api/reporting/server" | ||
| "github.com/chef/automate/components/compliance-service/ingest/events/compliance" | ||
| "github.com/chef/automate/components/compliance-service/reporting/relaxting" | ||
| "github.com/chef/automate/components/compliance-service/inspec" | ||
| iam_v2 "github.com/chef/automate/api/interservice/authz/v2" | ||
| ) | ||
|
|
||
| func TestListProfiles(t *testing.T) { | ||
| es2Backend := relaxting.ES2Backend{ESUrl: elasticsearchUrl} | ||
| server := reportingServer.New(&es2Backend) | ||
|
|
||
| reportFileName := "../ingest/examples/compliance-success-tiny-report.json" | ||
| everythingCtx := contextWithProjects([]string{authzConstants.AllProjectsExternalID}) | ||
|
|
||
| n := 5 | ||
|
|
||
| reportIds := make([]string, n) | ||
|
|
||
| for i := 0; i < n; i++ { | ||
| err := suite.ingestReport(reportFileName, func(r *compliance.Report) { | ||
| id := newUUID() | ||
|
|
||
| r.Environment = id | ||
| r.NodeName = id | ||
| r.Platform.Name = id | ||
| r.Profiles[0].Controls = r.Profiles[0].Controls[:1] | ||
| r.Profiles[0].Controls[0].Id = id | ||
| r.Profiles[0].Controls[0].Title = id | ||
| r.Profiles = r.Profiles[:1] | ||
| r.Profiles[0].Sha256 = id | ||
| r.Profiles[0].Title = id | ||
| r.Recipes = []string{id} | ||
| r.ReportUuid = id | ||
| r.Roles = []string{id} | ||
| r.EndTime = time.Now().UTC().Format(time.RFC3339) | ||
|
|
||
| reportIds[i] = id | ||
| }) | ||
|
|
||
| require.NoError(t, err) | ||
| } | ||
|
|
||
| defer suite.DeleteAllDocuments() | ||
|
|
||
| waitFor(func() bool { | ||
| response, _ := server.ListReports(everythingCtx, &reporting.Query{}) | ||
|
|
||
| return response != nil && len(response.Reports) == n | ||
| }) | ||
|
|
||
| reportsProjects := map[string][]string{ | ||
| "project1": reportIds[1:3], | ||
| "project2": reportIds[2:5], | ||
| "project3": reportIds[3:], | ||
| } | ||
|
|
||
| projectRules := map[string]*iam_v2.ProjectRules{} | ||
| for k, v := range reportsProjects { | ||
| projectRules[k] = &iam_v2.ProjectRules{ | ||
| Rules: []*iam_v2.ProjectRule{ | ||
| { | ||
| Conditions: []*iam_v2.Condition{ | ||
| { | ||
| Type: iam_v2.ProjectRuleConditionTypes_ROLES, | ||
| Values: v, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| // Send a project rules update event | ||
| esJobID, err := suite.ingesticESClient.UpdateReportProjectsTags(everythingCtx, projectRules) | ||
| assert.Nil(t, err) | ||
|
|
||
| suite.WaitForESJobToComplete(esJobID) | ||
|
|
||
| suite.RefreshComplianceReportIndex() | ||
|
|
||
| esJobID, err = suite.ingesticESClient.UpdateSummaryProjectsTags(everythingCtx, projectRules) | ||
| assert.Nil(t, err) | ||
|
|
||
| suite.WaitForESJobToComplete(esJobID) | ||
|
|
||
| suite.RefreshComplianceSummaryIndex() | ||
|
|
||
| profileIds := make([]string, len(reportIds)) | ||
| for i := range reportIds { | ||
| profileId := reportIds[i] | ||
| profileIds[i] = profileId | ||
|
|
||
| profile := inspec.Profile{ | ||
| Name: "a", | ||
| Title: "b", | ||
| Version: "1", | ||
| Sha256: profileId, | ||
| } | ||
|
|
||
| err := es2Backend.StoreProfile(profile) | ||
| require.NoError(t, err) | ||
| } | ||
|
|
||
| successCases := []struct { | ||
| description string | ||
| allowedProjects []string | ||
| expectedIds []string | ||
| }{ | ||
| { | ||
| description: "Projects: user has access to all projects", | ||
| allowedProjects: []string{authzConstants.AllProjectsExternalID}, | ||
| expectedIds: profileIds, | ||
| }, | ||
| { | ||
| description: "Projects: user has access to one project with reports", | ||
| allowedProjects: []string{"project1"}, | ||
| expectedIds: profileIds[1:3], | ||
| }, | ||
| { | ||
| description: "Projects: user has access to some projects with reports", | ||
| allowedProjects: []string{"project1", "project2"}, | ||
| expectedIds: profileIds[1:5], | ||
| }, | ||
| { | ||
| description: "Projects: user has access to projects without reports", | ||
| allowedProjects: []string{"project4", "project5"}, | ||
| expectedIds: []string{}, | ||
| }, | ||
| { | ||
| description: "Projects: user has access to one project with reports and unassigned reports", | ||
| allowedProjects: []string{"project1", authzConstants.UnassignedProjectID}, | ||
| expectedIds: profileIds[:3], | ||
| }, | ||
| { | ||
| description: "Projects: user has access to some projects with reports and unassigned reports", | ||
| allowedProjects: []string{"project1", "project2", authzConstants.UnassignedProjectID}, | ||
| expectedIds: profileIds[:5], | ||
| }, | ||
| { | ||
| description: "Projects: user has access to projects without reports and unassigned reports", | ||
| allowedProjects: []string{"project4", "project5", authzConstants.UnassignedProjectID}, | ||
| expectedIds: profileIds[:1], | ||
| }, | ||
| { | ||
| description: "Projects: user has access to unassigned reports", | ||
| allowedProjects: []string{authzConstants.UnassignedProjectID}, | ||
| expectedIds: profileIds[:1], | ||
| }, | ||
| } | ||
|
|
||
| for _, test := range successCases { | ||
| t.Run(test.description, func(t *testing.T) { | ||
| ctx := contextWithProjects(test.allowedProjects) | ||
|
|
||
| response, err := server.ListProfiles(ctx, &reporting.Query{}) | ||
|
|
||
| assert.NoError(t, err) | ||
| require.NotNil(t, response) | ||
|
|
||
| assert.Equal(t, len(test.expectedIds), int(response.Counts.Total)) | ||
|
|
||
| actualIds := make([]string, len(response.Profiles)) | ||
| for i, profile := range response.Profiles { | ||
| actualIds[i] = profile.Id | ||
| } | ||
|
|
||
| assert.ElementsMatch(t, test.expectedIds, actualIds) | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters