Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subscribing to association columns #11

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

cheerfulstoic
Copy link
Owner

@cheerfulstoic cheerfulstoic commented Jul 20, 2024

Fixes #6

Discussion here: #7

Need to update the README with these changes 😅

I'm definitely not happy with this code 😅 But it's pretty well tested and so it seems to work for now. I'm planning on switching messages to three-element tuples instead of four-element tuples (see this discussion) and that will be a good opportunity to clean things up

@cheerfulstoic
Copy link
Owner Author

Hey @barrelltech

I finally got an implementation for #6. I feel pretty good about the tests and I would normally release it on Hex, but I'm going to be offline for a bit, so I'll wait until I'm back. In the meantime maybe you'd like to try pointing to this branch in your mix.exs?

@cheerfulstoic
Copy link
Owner Author

To make it easier to try out I've released a 0.6.0-rc1 version

@cheerfulstoic
Copy link
Owner Author

You might also want to check out rc2 which includes the changes in this PR: #12

@barrelltech
Copy link
Contributor

Awesome! Just saw this now and downloaded it, but I won't get to it until tomorrow. Had to get things deployed before I got too far behind 😂

@cheerfulstoic cheerfulstoic merged commit 25b264f into main Jul 29, 2024
@cheerfulstoic cheerfulstoic deleted the add-subscribe-to-associations branch July 29, 2024 10:24
@cheerfulstoic
Copy link
Owner Author

I just released 0.6.0 as a non-RC version to support this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listening for events based on extras
2 participants