Elixir & Credo updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheerfulstoic
approved these changes
Aug 16, 2024
| @@ -235,7 +235,7 @@ defmodule TodoOrDie.AlertTest do | |||
|
|
|||
| assert( | |||
| message == | |||
| "Found a TOTEST tag: Test String (WAS UNABLE TO CHECK THE ISSUE - GOT ERROR: `{:tls_alert, 'internal error'}`)" | |||
| "Found a TOTEST tag: Test String (WAS UNABLE TO CHECK THE ISSUE - GOT ERROR: `{:tls_alert, ~c\"internal error\"}`)" | |||
|
Thanks so much! Published as 0.4.1 🎉 A matrix for testing would be awesome! It seems like GitHub actions failed, so maybe something more fundamental needs to be fixed. If you could fix both it would be amazing 🤘 |
|
Thanks for the quick merge and release! I'll take a peek at getting CI working again with my personal account this weekend, just for fun 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few small changes so that the library works with the latest elixir and credo releases.
I didn't go back and add in matrix testing to verify that different mixes of OTP/Elixir and Credo itself work, or add changelog entries, but am happy to do so as part of this