-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning message when tracker cannot ping machine-exec #443
Conversation
f8c5bc1
to
48d7b05
Compare
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-443-amd64 |
2 similar comments
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-443-amd64 |
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-443-amd64 |
97387b3
to
d415992
Compare
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-443-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code/extensions/che-activity-tracker/src/activity-tracker-service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment about resetting the value of this.errorDisplayed
variable when popup is closed. Everything else looks good.
Pinging the idling service is restored in a minute and it looks like we need to sow the popup again on failure.
@dkwon17 |
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
…ice.ts Co-authored-by: Vitaliy Gulyy <[email protected]>
1a83a27
to
64ca266
Compare
I've rebased against main and force pushed to my branch |
Pull Request images published ✨ Editor: quay.io/che-incubator-pull-requests/che-code:pr-443-amd64 |
Build 3.18 :: code_3.x/1499: Console, Changes, Git Data |
What does this PR do?
This PR displays an error message to the user if the activity tracker extension fails to ping che-machine-exec. The activity tracker extension regularly pings che-machine-exec to prevent dev environment idling, therefore if the ping fails, this PR lets the user know that their workspace might idle.
What issues does this PR fix?
Fixes eclipse-che/che#23134
How to test this PR?
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebase
were added to the .rebase folder