Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message when tracker cannot ping machine-exec #443

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Oct 23, 2024

What does this PR do?

This PR displays an error message to the user if the activity tracker extension fails to ping che-machine-exec. The activity tracker extension regularly pings che-machine-exec to prevent dev environment idling, therefore if the ping fails, this PR lets the user know that their workspace might idle.

What issues does this PR fix?

Fixes eclipse-che/che#23134

How to test this PR?

  1. Create a workspace with the PR image as the editor URL
  2. In the editor, run the following to terminate the che-machine-exec process:
// find machine-exec pid
ps -aux

kill -9 <pid>
  1. Make any file edits in the editor.
  2. Wait about 1 minute. After one minute, the error notification should appear:
    image
  3. Click on "View Logs" to view the error message in the extension's output:

image

Does this PR contain changes that override default upstream Code-OSS behavior?

  • the PR contains changes in the code folder (you can skip it if your changes are placed in a che extension )
  • the corresponding items were added to the CHANGELOG.md file
  • rules for automatic git rebase were added to the .rebase folder

Copy link

github-actions bot commented Oct 23, 2024

Click here to review and test in web IDE: Contribute

Copy link

2 similar comments
Copy link

Copy link

@dkwon17 dkwon17 marked this pull request as ready for review October 24, 2024 00:41
Copy link

Copy link
Collaborator

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionality - it works well for me!

image

Copy link
Contributor

@vitaliy-guliy vitaliy-guliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment about resetting the value of this.errorDisplayed variable when popup is closed. Everything else looks good.
Pinging the idling service is restored in a minute and it looks like we need to sow the popup again on failure.

@RomanNikitenko
Copy link
Collaborator

@dkwon17
PR's checks fail because of the known issue, I've fixed it in the main branch,
so, please fetch recent changes from the main branch.

@dkwon17
Copy link
Contributor Author

dkwon17 commented Nov 14, 2024

I've rebased against main and force pushed to my branch

Copy link

@RomanNikitenko RomanNikitenko merged commit 7f5c443 into che-incubator:main Nov 14, 2024
7 checks passed
@devstudio-release
Copy link

Build 3.18 :: code_3.x/1499: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show error if activity tracker extension fails to ping machine-exec
4 participants