feat: allow scanning multiple securejoin QR codes in parallel #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
5 times, most recently
from
b6e1266 to
e5da465
Compare
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
c4082de to
40718db
Compare
link2xt
changed the title
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
72eb02b to
3285bc5
Compare
|
The only problem still not figured out is how to cleanup old bob states. Every time Alice does not reply with I created #6536 issue for this, but don't plan to fix it in this PR. |
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
3285bc5 to
5fec0bf
Compare
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
5fec0bf to
7cfa784
Compare
iequidoo
approved these changes
Feb 19, 2025
Hocuri
approved these changes
Feb 20, 2025
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
414c91a to
f9021ba
Compare
link2xt
force-pushed
the
link2xt/securejoin-multiple-bob-states
branch
from
f9021ba to
bbb2673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6531
bobstaterow is now only created when Bob sendsvc-requestorvg-request, i.e. when Bob does not have Alice's key yet. It is removed as soon as Bob sends outvc-request-with-authorvg-request-with-auth.next_stepcolumn is now unused, because allbobstaterows correspond to the same step, waiting for*-request-with-auth.