feat: mark 1:1 chat as verified for Bob early #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly all the tests pass. But this actually needs a new test that checks we can get two-way verification without exchanging any securejoin messages. |
iequidoo
approved these changes
Dec 20, 2023
src/securejoin/bob.rs
Outdated
| @@ -100,6 +100,9 @@ pub(super) async fn handle_auth_required( | |||
| let chat_id = bobstate.joining_chat_id(context).await?; | |||
| chat::add_info_msg(context, chat_id, &msg, time()).await?; | |||
| } | |||
| bobstate | |||
| .notify_peer_verified(context, message.timestamp_sent) | |||
There was a problem hiding this comment.
notify_peer_verified() doesn't look like a good function name. It not only notifies the user, but also sets the chat protection. Maybe just set_peer_verified()?
There was a problem hiding this comment.
I renamed it and going to merge this PR into #5089 now.
link2xt
force-pushed
the
link2xt/peerstate-second-dir-verification
branch
3 times, most recently
from
9289de6 to
c2df003
Compare
Mark 1:1 chat as verified as soon as Alice is forward-verified so Bob can already start sending Chat-Verified headers. This way Alice and Bob can scan each other's QR codes and even if all Secure-Join headers are dropped from the network, still get forward verifications via QR-code scans and backward verifications via Chat-Verified messages in 1:1 chat.
link2xt
force-pushed
the
link2xt/mark-1-1-chat-verified-early
branch
from
e0ee897 to
8361541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #5089
Mark 1:1 chat as verified as soon as Alice is forward-verified
so Bob can already start sending Chat-Verified headers.
This way Alice and Bob can scan each other's QR codes
and even if all Secure-Join headers are dropped from the network,
still get forward verifications via QR-code scans
and backward verifications via Chat-Verified messages in 1:1 chat.